make sure that -just-plugin always stops after the plugin-build phase#130
Merged
gasche merged 1 commit intoocaml:masterfrom Dec 19, 2016
Merged
make sure that -just-plugin always stops after the plugin-build phase#130gasche merged 1 commit intoocaml:masterfrom
gasche merged 1 commit intoocaml:masterfrom
Conversation
gasche
force-pushed
the
just-plugin-no-plugin
branch
from
242149f to
bb34c86
Compare
Member
Author
|
See also #129 for a discussion of the |
Member
|
@gasche ping? |
Member
Author
|
Well... I guess I can merge -- after fixing the conflicts. |
gasche
force-pushed
the
just-plugin-no-plugin
branch
from
bb34c86 to
e65ca06
Compare
Previously -just-plugin would only be checked at the end of plugin build, and plugin build would only run if there is a plugin. This means that -just-plugin would be ignored if there was no myocamlbuild.ml: (ocamlbuild -just-plugin foo.byte) would build the target or not depending on whether a plugin source was present.
Member
|
Thanks a lot! When do you think I can expect a release of ocamlbuild? |
Member
Author
|
Well, whenever. Maybe in the next few days. Thanks for asking. |
Member
Author
|
(I'm preparing the release right now.) |
Member
Author
Member
|
Many thanks! |
Member
|
@gasche I don't know how but this seems broken in master... |
Member
|
@gasche Oh, I see now. We misunderstood each other. In essence what I want is for ocamlbuild to not pass -toolchain when building a plugin, ever. If this is really desirable (which it never will be), -plugin-option is there. |
Member
|
So, #160. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
-just-pluginwould only be checked at the end of pluginbuild, and plugin build would only run if there is a plugin. This
means that
-just-pluginwould be ignored if there was nomyocamlbuild.ml: the commandocamlbuild -just-plugin foo.bytewould build the target or not depending on whether a plugin source
was present.
This issue was reported by @whitequark in dbuenzli/topkg#87.